fix: set GRUB_CMDLINE_LINUX_DEFAULT
#982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@sticky-note - please amend your commit with the required sign-off. Once updated, we'll be able to review and proceed. Thanks! Ryan Johnson |
|
@sticky-note - if you are uncomfortable adding the sign-off, please let me know and I'll add the fix seperately. |
tenthirtyam
force-pushed
the
fix/ubuntu
branch
from
bdddb54 to
c6d0ade
Compare
tenthirtyam
changed the title
GRUB_CMDLINE_LINUX_DEFAULT
Reestablish an empty `GRUB_CMDLINE_LINUX_DEFAULT` as `late_command`. Signed-off-by: sticky-note <[email protected]>
tenthirtyam
force-pushed
the
fix/ubuntu
branch
from
c6d0ade to
8c8ed36
Compare
tenthirtyam
pushed a commit
that referenced
this pull request
Dec 2, 2024
Reestablish an empty `GRUB_CMDLINE_LINUX_DEFAULT` as `late_command`. Signed-off-by: sticky-note <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Pull Request
I ran into #981 today, it seems to come from
GRUB_CMDLINE_LINUX_DEFAULTbeing set onpackertemplate provisioning viacloud-initinstaller.It is set by packer
boot_commandon kernel cmdline arguments and tellcloud-initto use a specific DataSource (nocloud-netornocloud) and the installer persists these arguments on grub configuration in/etc/default/grub.It it the reason why
cloud-initdoes not readVMwareDataSource.I ended up with this Pull Request to restablish an empty
GRUB_CMDLINE_LINUX_DEFAULTaslate_commandIt works on my side
Tested on
Ubuntu 22.04 LTSHope it'll help someone.
Type of Pull Request
type/bugtype/featureortype/enhancementtype/docstype/refactortype/chorePlease describe:
Related to Existing Issues
Closes #981
Test and Documentation Coverage
Breaking Changes?